Fix sticker pack banner CDN path including specific application ID #7295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Iirc it was because this route is exclusive for nitro sticker packs and the banner images were saved in that specific application. Might be wrong but I remember something along these lines. |
Contributor
Author
Ah that's funny. A note somewhere mentioning that would be nice but I'll close the PR :) |
Contributor
|
Yeah, GET {
"id": "710982414301790216",
"name": "Stickers",
"icon": null,
"description": "",
"summary": "",
"type": null,
"is_monetized": false,
"is_verified": false,
"is_discoverable": false,
"hook": true,
"storefront_available": false,
"integration_types_config": {
"0": {}
},
"verify_key": "4be0b338ea2e6b55ca654be7d08534b99260888d08b7f2636cca1a962a5cd21b",
"flags": 0
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this path has an actual application ID in it instead of the hyperlink to the application object. It's obvious enough what it means, but it you took it at face value you'd be trying to fetch app assets off some random bot not your own lol